Commit Briefs

087855b83c Thomas Adam

revert part of my previous commit which caused unstage.sh test failures (portable)

Some parts of the code rely on staged_blob_id being NULL in certain cases. Restore this behaviour while keeping the segfault bug fixed.


af0328d61e Thomas Adam

fix a crash when unstaging a file which has been removed from disk

reported by Johannes Thyssen Tishman


ad4a705039 Thomas Adam

plug a memory leak in got_privsep_recv_send_remote_ref

We didn't always call imsg_free(); while here also fix the `default` branch so it actually errors on unexpected messages. Diff from Kyle Ackerman with tweaks from tb@



fc1e772f39 Thomas Adam

remove a todo item that's done


28a5e8a277 Thomas Adam

fix pack file creation in the presence of tagged tag objects

If a repository contains a tag that tags another tag we could fail with a "bad object data" error while creating pack files because the packed-object-enumeration code assumed that only commits get tagged, trying to parse the tagged tag object as if it were a commit. This issue affected 'got send' and 'gotadmin pack'. There is probably more work to do here because other weird cases are known to exist in the wild, such as git.git's refs/tags/junio-gpg-pub which tags a blob. Problem with 'got send' reported by jrick@


3e6e13b22e Thomas Adam

prevent tog segfault upon unexpected object type in ref list view

If an unexpected object type is found while resolving a reference in the ref view, have tog exit with an "unknown object type" error instead of crashing. Found while playing with a repo which contains tags that tag tags.


856eeb981b Thomas Adam

add a todo item



ddbb3188df Thomas Adam

make got_object_open_loose_fd() return NO_OBJ error upon ENOENT

Some callers were manually converting from ENOENT to NO_OBJ. Checking errno becomes increasingly unreliable the further up the call-chain we return to. Let's return NO_OBJ directly at the spot where the original error condition is detected.


961964db5e Thomas Adam

trailing whitespace; from man -Tlint



82fb769c61 Thomas Adam

portable: set next version


83604bb52f Thomas Adam

portable: release 0.103 (tags/0.103)


851f7c92c7 Thomas Adam

use _POSIX_HOST_NAME_MAX instead of HOST_NAME_MAX

this is to help -portable. Some systems don't define HOST_NAME_MAX at all, and assume instead that code will use sysctl(_SC_HOST_NAME_MAX) with a VLA or a dynamic allocation, which is completely backward and useless. So, use the _POSIX hammer on this one too. it's dirty, but it's better to strive to avoid gratious -portable changes. reported and discussed with Thomas Adam.


c649655b96 Thomas Adam

portable: update for gotd-secrets


d128e1f1bf Thomas Adam

bump version number


43b0094d4f Thomas Adam

CHANGES for 0.103



b0d2a5e995 Thomas Adam

sync dist file list



f256d99d18 Thomas Adam

fix documentation of auth keyword in gotd.conf.5


89ce447646 Thomas Adam

wording improvements for gotd-secrets.conf man page


99e753aa3e Thomas Adam

traverse regress/secrets during 'make regress'